Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: First draft of Listbox component #2202

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

POC: First draft of Listbox component #2202

wants to merge 7 commits into from

Conversation

jandrade
Copy link
Member

@jandrade jandrade commented Apr 3, 2024

Summary:

Playing around with Listbox + Combobox.

This is mostly used for reference in the Implementation spec.

Issue: XXX-XXXX

Test plan:

TBD

@jandrade jandrade self-assigned this Apr 3, 2024
Copy link

changeset-bot bot commented Apr 3, 2024

⚠️ No Changeset found

Latest commit: b95817e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Size Change: +522 B (+1%)

Total Size: 93.1 kB

Filename Size Change
packages/wonder-blocks-dropdown/dist/es/index.js 12.6 kB +315 B (+3%)
packages/wonder-blocks-tooltip/dist/es/index.js 5.26 kB +207 B (+4%)
ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 3.78 kB
packages/wonder-blocks-banner/dist/es/index.js 1.53 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.72 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 1.13 kB
packages/wonder-blocks-button/dist/es/index.js 4.28 kB
packages/wonder-blocks-cell/dist/es/index.js 2.24 kB
packages/wonder-blocks-clickable/dist/es/index.js 3.3 kB
packages/wonder-blocks-core/dist/es/index.js 3.7 kB
packages/wonder-blocks-data/dist/es/index.js 6.33 kB
packages/wonder-blocks-form/dist/es/index.js 5.32 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-i18n/dist/es/index.js 4.56 kB
packages/wonder-blocks-icon-button/dist/es/index.js 3.21 kB
packages/wonder-blocks-icon/dist/es/index.js 1.06 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.89 kB
packages/wonder-blocks-link/dist/es/index.js 2.54 kB
packages/wonder-blocks-modal/dist/es/index.js 5.52 kB
packages/wonder-blocks-pill/dist/es/index.js 1.27 kB
packages/wonder-blocks-popover/dist/es/index.js 4.86 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.51 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.55 kB
packages/wonder-blocks-switch/dist/es/index.js 2.1 kB
packages/wonder-blocks-testing/dist/es/index.js 3.94 kB
packages/wonder-blocks-theming/dist/es/index.js 697 B
packages/wonder-blocks-timing/dist/es/index.js 1.78 kB
packages/wonder-blocks-tokens/dist/es/index.js 1.69 kB
packages/wonder-blocks-toolbar/dist/es/index.js 857 B
packages/wonder-blocks-typography/dist/es/index.js 1.49 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Apr 3, 2024

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-ocnzsgblat.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 328
Tests with visual changes 13
Total stories 414
Inherited (not captured) snapshots [TurboSnap] 0
Tests on the build 328

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Merging #2202 (e8ed92a) into main (41aa407) will decrease coverage by 0.35%.
Report is 3 commits behind head on main.
The diff coverage is 27.96%.

❗ Current head e8ed92a differs from pull request most recent head b95817e. Consider uploading reports for the commit b95817e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2202      +/-   ##
==========================================
- Coverage   94.48%   94.13%   -0.35%     
==========================================
  Files         248      249       +1     
  Lines       28660    29078     +418     
  Branches     2331     2368      +37     
==========================================
+ Hits        27079    27374     +295     
- Misses       1577     1671      +94     
- Partials        4       33      +29     
Files Coverage Δ
...der-blocks-dropdown/src/components/option-item.tsx 97.20% <89.83%> (+1.41%) ⬆️
.../wonder-blocks-dropdown/src/components/listbox.tsx 0.00% <0.00%> (ø)

... and 50 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41aa407...b95817e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant