WB-1676: Combobox - Add multiple Selection support #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 265751e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +985 B (+1.01%) Total Size: 98.8 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-hlfeyayxwv.chromatic.com/ Chromatic results:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## combobox-single #2223 +/- ##
===================================================
+ Coverage 94.72% 95.26% +0.54%
===================================================
Files 249 251 +2
Lines 29736 30046 +310
Branches 2447 2453 +6
===================================================
+ Hits 28166 28624 +458
+ Misses 1543 1412 -131
+ Partials 27 10 -17
... and 31 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (a52e000) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2223"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2223 |
jeresig
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Create the multiple version that displays the selected values as individual Pill
components that can be deleted/unchecked.
Added a new hook to manage keyboard navigation for the multiple selection logic.
Combobox Implementation Plan:
Listboxcomponent with Single and Multiple selection support #2216Comboboxcomponent.[CURRENT]Comboboxcomponent.Comboboxcomponent.Issue: https://khanacademy.atlassian.net/browse/WB-1676
Test plan:
Keyboard navigation instructions (when the combobox is focused):
Arrow Up | Arrow Down: to navigate the listbox optionsArrow left | Arrow right: to navigate the selected options (pills displayed before the input)Backspace: removes the last pill in the stackEnter:Screen.Recording.2024-05-09.at.4.24.30.PM.mov