Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for
[[sycl::reqd_work_group_size]]
exception when mismatchednd_range
was given #285Test for
[[sycl::reqd_work_group_size]]
exception when mismatchednd_range
was given #285Changes from 9 commits
3822a72
b03925a
d50c118
ee28a82
a02a67f
88bda24
373ae90
9871be2
bb33e39
36a27b4
78147fe
e09a86b
8d399e3
12d9404
9bb4f1a
329bbbb
b790797
951f4ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the spec:
You've marked two implementations in the CI as not passing (adding the test to the filter), but I believe they should be able to pass the test even if they don't implement the features, otherwise they wouldn't be able to pass conformance in the current CTS design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand CI doesn't run tests, it's just built it. Here you can find output from the building of tests on CI. ComputeCpp and hipsycl failed building due to some errors.
From hipsycl logs, line 1970:
error: ‘errc’ is not a member of ‘sycl’
. Looks like enum with error codes is not implemented yet and attributes too (line 1966).Similar situation for computecpp.
But maybe I was wrong when I put these two implementations in the filter because both of them give the error message:
no known conversion from 'cl::sycl::nd_item<1>' to 'sycl::item<1>'
error, so it can be bug of tests itself.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was my mistake. I changed to
nd_item
but now getting another error. Right now investigating it.