Bump Catch2 to d548be26 for new SKIP macro #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProGTX
approved these changes
Jan 12, 2023
bader
reviewed
Jan 12, 2023
tests/kernel_bundle/has_kernel_bundle_throws_diff_dev_from_one_platform_dev.cpp
Outdated
Show resolved
Hide resolved
bader
approved these changes
Jan 17, 2023
- Change most locations with manual skip message to use the new SKIP macro. Some legacy tests with more complex control flow still use manual messages. - Update developer documentation to recommend the use of SKIP macro when testing optional features.
|
Rebased onto current SYCL-2020 branch and resolved conflicts. There were no new opportunities for converting to SKIP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm glad to announce that support for the long-awaited
SKIPmacro has been merged into Catch2!This PR bumps the revision of the Catch2 submodule to current
develand adjusts most tests to use the new macro instead of manually printing a message and returning. The main advantage of using the macro is that test cases are reported explicitly as "skipped" instead of "failed" or "passed". This in turn will allow us to handle skipped tests separately in conformance report generation, which will become important once we start to decide on which test cases are required and which ones are optional for conformance.The
SKIPmacro behaves essentially like a manualFAIL, in that it is the last thing executed in a test case. For this reason some of the legacy tests with more complex control flow still print manual skip messages, as they require some restructuring first (or rather, they should be converted to Catch2).I've also updated the developer documentation to recommend the use of the
SKIPmacro when testing optional features.