Add UnityGLTFShaderVariants for issue: https://github.com/KhronosGrou… #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,5 @@ | |||
| // Upgrade NOTE: replaced 'UNITY_INSTANCE_ID' with 'UNITY_VERTEX_INPUT_INSTANCE_ID' | |||
There was a problem hiding this comment.
Personally I don't think .cginc file should be included in the PR for compatibility concerns.
There was a problem hiding this comment.
How to modify the PR?
There was a problem hiding this comment.
|
Thanks for the PR! |
|
Sorry for the delay on responding to this. @JohnCopicMS had some opinions about how to deal with this issue in the repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…p/UnityGLTF/issues/206
See: #206
This include: UnityGLTFShaderVariant in UnityGLTF/Assets/Resources/ but also in GraphicsSettings.
Please check all ok!