Skip to content

Commit

Permalink
Avoid using the CSS href as the link tag key (vercel#41493)
Browse files Browse the repository at this point in the history
There is no need to use the href as key in our case because it's pure
during SSR and it won't re-order on the client. By using `index` we can
avoid some duplicate bytes here:

![CleanShot 2022-10-18 at 00 21
20@2x](https://user-images.githubusercontent.com/3676859/196295175-c5b437f7-0ae9-4d89-9d96-9594686168ae.png)

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
  • Loading branch information
shuding authored and Kikobeats committed Oct 24, 2022
1 parent ad9bdc5 commit 63b48f7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/next/server/app-render.tsx
Expand Up @@ -1115,7 +1115,7 @@ export async function renderToHTMLOrFlight(
)
})}
{stylesheets
? stylesheets.map((href) => (
? stylesheets.map((href, index) => (
<link
rel="stylesheet"
href={`${assetPrefix}/_next/${href}${cacheBustingUrlSuffix}`}
Expand All @@ -1124,7 +1124,7 @@ export async function renderToHTMLOrFlight(
// https://github.com/facebook/react/pull/25060
// @ts-ignore
precedence="high"
key={href}
key={index}
/>
))
: null}
Expand Down

0 comments on commit 63b48f7

Please sign in to comment.