Fix MacOS makefile vvars #339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this an issue for a specific version of macOS? I'm on Sonoma 14.3 (Apple Silicon M2) and have no issues with the OS detection as it is implemented in branch |
|
Not sure, We had a user reporting this as an issue but i cant for the life of my find the issue report now |
|
Closing as seems to be unnecessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advantage 360 Pro PR template
What's changed:
The OS auto detection in the makefile has been expanded so more variables are not quoted when running under MacOS
Why has this change been implemented:
#335 Broke compatibility on MacOS
What (if any) actions must a user take after this change:
No additional actions need to be taken