Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error formatting #32

Merged
merged 1 commit into from Jul 21, 2023
Merged

Improved error formatting #32

merged 1 commit into from Jul 21, 2023

Conversation

halostatue
Copy link
Member

@halostatue halostatue commented Jul 20, 2023

Technical Change Notes

This now uses GitHub core.summary. See the job summaries blog
post.

There are some changes caused by annoying upgrades:

Signed-off-by: Austin Ziegler aziegler@kineticcommerce.com

@halostatue halostatue force-pushed the improve-error-formatting branch 2 times, most recently from 857c6d7 to b8d893b Compare July 21, 2023 00:58
Technical Change Notes
======================

This now uses GitHub `core.summary`. See the [job summaries][] blog
post.

There are some changes caused by annoying upgrades:

- Added a `.envrc` to ensure local builds and tests use Node 16.
- Prettier 3 changes formatting defaults.
- PNPM 8 also changes some defaults. Added a project `.npmrc` to
  work around pnpm/pnpm#6312.
- Removed tests and jest.
- Upgraded all dev dependencies.

[job summaries]: https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/

Signed-off-by: Austin Ziegler <aziegler@kineticcommerce.com>
@halostatue halostatue self-assigned this Jul 21, 2023
Copy link

@mikestok mikestok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, but I don’t have an understanding of the bigger context.

dist/index.js Show resolved Hide resolved
dist/index.js.map Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@halostatue halostatue added this pull request to the merge queue Jul 21, 2023
Merged via the queue into main with commit c9c1570 Jul 21, 2023
6 checks passed
@halostatue halostatue deleted the improve-error-formatting branch July 21, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants