-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Buffer" progress bar #685
Conversation
#684 FYI. |
@@ -27,7 +27,7 @@ public static IEnumerable<Record> ReadRecords(byte[] binlogBytes) | |||
|
|||
public static Build ReadBuild(string filePath) => ReadBuild(filePath, progress: null); | |||
|
|||
public static Build ReadBuild(string filePath, Progress progress) | |||
public static Build ReadBuild(string filePath, Progress progress, Progress bufferUsage = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, I hadn't realized that this is breaking public API.
Unfortunately I will have to back it out. Sorry about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. Do revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good old overloads are still a thing.
I merged this PR optimistically, but upon reflection I think I'm going to have to revert it.
|
|
Don't worry about it, I just pushed the revert: |
I would like to avoid regular users paying any perf costs just for developer monitoring tooling. Your buffer utilization progress bar is good, as well as the perf counters, but stuff like this is good to keep in the branch perhaps. Feel free to make a branch with the revert of efb0a57 and use it for local testing. Don't think we need this in the main branch. |
Add a "Buffer" progress bar that will report the BlockingCollection queue length.
Add a "Log Processing Statistics" to report the performance of the each type events.
Add a menu option to clear recently opened history.