Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable threading on browser #694

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Disable threading on browser #694

merged 2 commits into from
Jul 25, 2023

Conversation

lambdageek
Copy link
Contributor

Fixes #690

@lambdageek
Copy link
Contributor Author

@KirillOsenkov @yuehuang010 Do you want PRs against main or live? I would prefer to push this to main (I'd like to use StructuredLogger on another platform that doesn't have threads)

@KirillOsenkov
Copy link
Owner

Let’s target main and I’ll merge into live. Thanks!!

@lambdageek lambdageek changed the base branch from live to main July 22, 2023 03:13
@lambdageek lambdageek closed this Jul 22, 2023
@lambdageek lambdageek reopened this Jul 22, 2023
@lambdageek
Copy link
Contributor Author

Rebased the PR on main

@lambdageek
Copy link
Contributor Author

This is ready to merge, @KirillOsenkov @yuehuang010

KirillOsenkov
KirillOsenkov approved these changes Jul 25, 2023
View reviewed changes
Copy link
Owner

@KirillOsenkov KirillOsenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

I was procrastinating on getting the WASM version working again after we added parallelism and it is a huge relief that you did it for us.

@KirillOsenkov KirillOsenkov merged commit 3afba45 into KirillOsenkov:main Jul 25, 2023
1 check passed
@KirillOsenkov
Copy link
Owner

Just fixed up the namespace a little bit:
cfd1aa9

@KirillOsenkov
Copy link
Owner

I've published the latest version to https://live.msbuildlog.com, thanks!

@lambdageek lambdageek deleted the fixup-live-site branch August 20, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuehuang010 yuehuang010 yuehuang010 left review comments

@KirillOsenkov KirillOsenkov KirillOsenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web version is broken
3 participants
@lambdageek @KirillOsenkov @yuehuang010