Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASI support and single-threading #700

Merged
merged 4 commits into from
Aug 27, 2023

Conversation

lambdageek
Copy link
Contributor

Cherry pick changes to the core log viewer from the VS Code extension
https://github.com/lambdageek/MSBuildStructuredLog/tree/wasi-single-thread

  • Add WASI support in PlatformUtilities - the .NET 8 WASI workload doesn't support threads, does not have Console colors and cannot assume that GetTempFileName will work (because WASI doesn't necessarily grant unrestricted filesystem access)
  • Replace a few parallel algorithms by single-threaded versions when threading isn't available.

lambdageek and others added 4 commits August 27, 2023 14:41
example:

```console
% wasmtime BinLogTool.wasm --dir . -- search example.binlog hello

    3 results. Search took: 00:00:00
    foo.proj
        Target Hello
        Target Hello
            Task Message
                Message  Hello World
    Item Hello
====================================
```
@lambdageek
Copy link
Contributor Author

I'm not upstreaming the VS Code extension's .NET "engine" or the associated TypeScript code yet, but the changes to the core of the viewer I think are more or less done and I don't expect to need to make many more.

Copy link
Owner

@KirillOsenkov KirillOsenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@KirillOsenkov KirillOsenkov merged commit afda0c9 into KirillOsenkov:main Aug 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants