Support for Extended Data #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIleVersion 17
|
Attached is binary log for testing if needed. |
|
this is nice! I think if extended data is available, we should manufacture a message as a child node of the extended event, and put the full text in there. Also if extended metadata is present, add metadata child nodes for each metadata |
|
See |
| @@ -549,7 +550,7 @@ | |||
| <Setter TargetName="messageText" Property="Opacity" Value="0.25" /> | |||
| </DataTrigger> | |||
| </DataTemplate.Triggers> | |||
There was a problem hiding this comment.
Probably need to change these to HierarchicalDataTemplate.Triggers
There was a problem hiding this comment.
Surprised that it works, but OK
KirillOsenkov
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing: dotnet/msbuild#9091
Context
MSBuild introduced new concept of Event args Extended data which are supposed to address need to extend events.
One of its most appealing use cases is for passing extended compiler error and warning structured information into msbuild logging infrastructure. Having such info in binlog and viewer might be of use.
Changes Made