Face get center API #330
Face get center API #330
Conversation
* add isometric struct * adjust nomenclature --------- Co-authored-by: gserena <serena@zoo.dev>
| #[derive(Debug, Clone, Serialize, Deserialize, JsonSchema, ExecutionPlanFromMemory, ModelingCmdVariant)] | ||
| pub struct FaceGetCenter { | ||
| /// Which face is being queried. | ||
| pub object_id: Uuid, |
There was a problem hiding this comment.
Shouldn't this be "face_id" as you're not querying an overall object, you're querying one specific face of an object?
There was a problem hiding this comment.
opted for consistency, see FaceGetGradient + FaceGetPosition which already use object_id
modeling-cmds/src/def_enum.rs
Outdated
| @@ -951,6 +958,14 @@ define_modeling_cmd_enum! { | |||
| pub padding: f32, | |||
| } | |||
|
|
|||
| /// Fit the view to the scene with an isometric view. | |||
| #[derive(Debug, Clone, Serialize, Deserialize, JsonSchema, ExecutionPlanFromMemory, ModelingCmdVariantEmpty)] | |||
| pub struct ViewIsometric { | |||
There was a problem hiding this comment.
So this zooms out to fill all objects within the scene?
There was a problem hiding this comment.
this was part of Serena's prior PR that already has merged into main. again, read my top comment about the diff.
|
k, main merged, diff cleaned up so its more clear. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
=======================================
Coverage ? 54.99%
=======================================
Files ? 51
Lines ? 5821
Branches ? 0
=======================================
Hits ? 3201
Misses ? 2620
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
this diff is going to look screwed up due to me having to reverse jump back to get around pre-emptive release of 0.2.24.