Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing multi-sketch file #1466

Merged
merged 7 commits into from May 22, 2024
Merged

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Feb 20, 2024

Adding context from Slack:

Edit Sketch only shows up for me for sketch #1, not for the two others

Code:

const width = 20
const height = 10
const thickness = 5
const screwRadius = 3
const wireRadius = 2
const wireOffset = 0.5

const screwHole = startSketchOn('XY')
  |> startProfileAt([-width / 4 + screwRadius, height / 2], %)
  |> arc({
       radius: screwRadius,
       angle_start: 0,
       angle_end: 360
     }, %)

const part001 = startSketchOn('XY')
  |> startProfileAt([-width / 2, 0], %)
  |> xLine(width * .5, %)
  |> yLine(height, %)
  |> xLine(-width * .5, %)
  |> close(%)
  |> hole(screwHole, %)
  |> extrude(thickness, %)

const part002 = startSketchOn('-XZ')
  |> startProfileAt([0, thickness], %)
  |> xLine(width / 4, %)
  |> tangentialArcTo([width / 2, 0], %)
  |> xLine(-width / 4 + wireRadius, %)
  |> yLine(wireOffset, %)
  |> arc({
       radius: wireRadius,
       angle_start: 0,
       angle_end: 180
     }, %)
  |> yLine(-wireOffset, %)
  |> xLine(-width / 4, %)
  |> close(%)
  |> extrude(-height, %)

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview May 22, 2024 4:16pm

jessfraz and others added 2 commits May 21, 2024 22:17
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz jessfraz marked this pull request as ready for review May 22, 2024 16:04
@jessfraz
Copy link
Contributor

@pierremtb i changed to ready to review because it seems like the test is passing let me know if thats wrong

@jessfraz jessfraz self-requested a review May 22, 2024 16:05
@jessfraz jessfraz merged commit e94b1bc into main May 22, 2024
16 checks passed
@jessfraz jessfraz deleted the pierremtb/playwright-multi-sketch branch May 22, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants