KCL: Refactor pipe bodies #1954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamchalmers
force-pushed
the
achalmers/refactor-pipe-bodies
branch
from
ced5835
to
80c22fd
Compare
adamchalmers
force-pushed
the
achalmers/refactor-pipe-bodies
branch
from
80c22fd
to
5fb04dd
Compare
adamchalmers
force-pushed
the
achalmers/refactor-pipe-bodies
branch
from
5fb04dd
to
18294ad
Compare
PipeExpressions should always have at least two child expressions. The first expression (the head) is a little different from the following subexpressions, because the head can be any value. But the remaining expressions (tail) must be function calls. This refactors the AST node for PipeExpression so that information is encoded in the type system, not just checked at runtime. Instead of a Vec<Value>, it should have a separate head Value and tail Vec<Value>.
adamchalmers
force-pushed
the
achalmers/refactor-pipe-bodies
branch
from
18294ad
to
511de64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PipeExpressions should always have at least two child expressions. The first expression (the head) is a little different from the following subexpressions, because the head can be any value. But the remaining expressions (tail) must be function calls.
This refactors the AST node for PipeExpression so that information is encoded in the type system, not just checked at runtime. Instead of a Vec, it should have a separate head Value and tail Vec.