Bug in sketch on face #1980
Closed
Bug in sketch on face #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'll link this Just because it's another situation where |
|
I'm not sure this is an engine bug -- it could be, but, this was working before when the modeling-app was double-executing the first command of each pipeline. I don't know why fixing that would break this. |
|
In case it's useful here's a log of the plumbus calls
|
Screenshare.-.2024-04-04.3_02_51.PM.mp4 |
|
Oh that's an interesting find, thank you Kurt. |
adamchalmers
force-pushed
the
achalmers/sketch-bug
branch
from
b12c199
to
d912123
Compare
expl-scaled.mp4TL;DR - the engine isn't invalidating ids and is handling things correctly no matter the order of how the extrusions/fillets are done, so keep checking into the modeling-app/executor for the cause of this issue. |
|
As a sanity check might be worth writing a test in the engine doing the exact same calls we are doing thats what i typically tend to do |
|
I could be like we are exiting sketch mode or something subtle |
|
I've tried to copy the API calls that the modeling app makes, and turn them into an engine unit test here: https://github.com/KittyCAD/engine/pull/1977 Weirdly, it works fine in the engine test. So I either copied the calls wrong, omitting the modeling-app's mistake, or there's something weird going on beyond just the API calls. Here's the debug prints from my latest commit on this PR. These debug prints show what modeling commands the app is sending to the engine. This was my guide for how to build the engine unit test. Note that I did a find-and-replace for several important UUIDs which get referenced a lot, e.g. the UUID of the command which starts the 2D pentagon's path is replaced by PENTAGON_ID. Anything in all caps is the name of a UUID. |
adamchalmers
force-pushed
the
achalmers/sketch-bug
branch
from
41ac5c0
to
a9291b2
Compare
|
OK, I think this is a bug related to defining sketches in functions. The plumbuses can be filletted just fine as long as the inlining_make_circle.mp4 |
weird_plumbus_behaviour.mp4 |
adamchalmers
force-pushed
the
achalmers/sketch-bug
branch
from
a9291b2
to
168959a
Compare
adamchalmers
force-pushed
the
achalmers/sketch-bug
branch
from
168959a
to
5895894
Compare
|
Fixed in #2474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add a second plumbus, but instead it fails because the tagged circle "arc-b" cannot be found.
The cause is that the API call to
Solid3dGetExtrusionFaceInforeturns 3ExtrusionFaceInfos when creating the first plumbus, but 0 for the second plumbus.once fixed will close #1894