-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fewer batches to sketch a cube #2049
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
… calls into one batch This means sketching a cube takes 2 batches, not 1.
65ab692
to
0937408
Compare
LGTM. I thought by now we could make it all 1 batch request. |
Hmm, this PR has a bug -- my "draw three cubes" program works fine in a Rust unit test, but doesn't actually work when I run the app. My theory is that something is broken in the WASM connection but not the normal Rust connection. |
22b2c9c
to
5055df5
Compare
5055df5
to
b3695c0
Compare
part of #1969
Previously, sketching a cube took 4 batches:
This means each cube takes 4 batches at 16ms each, so, 66ms per cube.
Now, there's only 2 batches (33ms per cube):
This can definitely be improved further, but I'm breaking into small PRs.