-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home page touch-ups #2135
Home page touch-ups #2135
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Some open questions:
|
we can definitely store the camera position, which will go more neatly into the project.toml than an actually image would. And Getting snap shots for projects the user hasn't open 🤷 not sure hey. |
Sorry I used imprecise language in the video, I meant just save the path to the image in I like the idea of using |
This PR resolves #2337 |
Start of an implementation toward #2133. Dialed back this to not include the screenshot functionality so we could land the PR sooner rather than later.
However, I'm going to keep this in draft form until we have a "zoom to fit" endpoint in the engine, and then use thetake_snapshot
modeling command to get a much more consistent snapshot.Another design dilemma I'm in is how to capture new snapshots from the home page. I want to make this more robust, so that when either:theapp.theme
setting is changeda project does not yet have a thumbnailthe card is put into a loading state and a new image is captured without leaving the home page
Demo with current limitations
Screenshare.-.2024-04-16.8_19_51.PM-compressed.mp4