Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom to fit on load #2201

Merged
merged 18 commits into from May 24, 2024
Merged

zoom to fit on load #2201

merged 18 commits into from May 24, 2024

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Apr 23, 2024 •
edited

closes #1874
closes #1872

waiting on https://github.com/KittyCAD/engine/issues/2098

  • add a test for on file load
const part001 = startSketchOn('XY')
  |> startProfileAt([-10, -10], %)
  |> line([20, 0], %)
  |> line([0, 20], %)
  |> line([-20, 0], %)
  |> close(%)

@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview May 24, 2024 0:05am

@jessfraz
Copy link
Contributor Author

@Irev-Dev i think i put this the wrong place because its being weird sorry!

jessfraz and others added 4 commits May 16, 2024 13:43
@jessfraz @Irev-Dev
zoom to fit on load
2c48f37 
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz @Irev-Dev
updates
363188f 
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz @Irev-Dev
lint
47b4072 
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@Irev-Dev
add zoom to fit calls to the correct places
ceab04b
@jessfraz jessfraz mentioned this pull request May 23, 2024
Closed
jessfraz and others added 3 commits May 23, 2024 16:23
@jessfraz
remove my enhancements
bdc9baf 
Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz jessfraz enabled auto-merge (squash) May 24, 2024 00:02
@jessfraz jessfraz mentioned this pull request May 24, 2024
Merged
@jessfraz jessfraz merged commit 87979b1 into main May 24, 2024
14 checks passed
@jessfraz jessfraz deleted the zoom-to-fit-on-load branch May 24, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zoom to correct grid not working as expected on new file open / paste new code we should zoom to model
2 participants
@jessfraz @Irev-Dev