Ensure that onboarding buttons are visible, even on short viewports #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dshaw pointed this out to me, that on certain devices the "Parametric modeling" onboarding step's buttons to dismiss or advance were hidden off the bottom of the screen, and he had to resort to zooming out to see them again.
Turns out that panel's height (and those of some of the other steps) were using percentages (via the TailwindCSS
h-3/4class) and I had forgotten that CSS percentage-based heights are based on the width of that element. What we wanted was 3/4 of the viewport, or75vh. I also added overflow behavior so the items don't bust out of their container on even shorter viewports.Before (from dshaw)
After