Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the routingHelper functions publicly available #1428

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Made the routingHelper functions publicly available #1428

wants to merge 1 commit into from

Conversation

sanderdekoning
Copy link

Description

By making the current two implemented routingHelper() functions in the router publicly available it allows a bit more abstraction by the user in terms of implementing generics if desired, by leveraging the use of the already public RouterMethod struct:

Instead of router.get('endpoint', handler:) I can now alternatively call router.routingHelper(.get, 'endpoint', handler:) if desired.

How Has This Been Tested?

-

Checklist:

  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sander de Koning seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sanderdekoning
Copy link
Author

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sander de Koning seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

I have signed the CLA, will the CLAssistant pick up on that automatically to resolve the pending status?

@djones6
Copy link
Collaborator

djones6 commented Mar 27, 2019

Hi @sdekoning0, can you elaborate a bit on your use-case for this?

The name routingHelper is not something I think we'd want to expose as public API, we'd want to rename that to something more descriptive if we do decide this should be public.

Regarding the CLA, it looks like your commit was pushed with an id that Github hasn't linked to your account, so the CLA assistant doesn't know the contribution is yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants