FIX StaticFileServer: no longer serve ended requests for SPA's #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If a defaultIndex is specified and a previous middleware ended the request, do not attempt to serve the static file
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a defaultIndex is specified and a previous middleware ended the
request, do not attempt to serve the static file
Description
When servicing a defaultIndex, first check whether a response has already been sent or that the response has ended.
Motivation and Context
If using StaticFileServer to serve an SPA (via defaultIndex) while also using routers to service API endpoints (e.g. that the static server may be communicating with), this will prevent the static server from appending the defaultIndex to the response.
How Has This Been Tested?
I have added a unit test to demonstrate and test for this situation.
Checklist: