Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support for ID and Query parameters. #1557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbarnach
Copy link
Member

Description

Add the support for GET with an ID and optional query parameters.
Supports the return of a single object or an array of objects.
The parameters are only optional in this PR, which is what is making sense most (all?) the time I think.
The return of a list of IDs only has not been done, but could also be added.

Swagger automatic documentation has been added.

Motivation and Context

Fix issue #1556 that reports the lack of such feature.

How Has This Been Tested?

A test has been added to the test list.

Checklist:

  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

This is fixing, at least partly, issue #1556
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
58.9% 58.9% Duplication

@adam-rocska
Copy link
Member

Oh my GAWD!

So sorry. If it wasn't for the GitHub widget on my iPad, this I wouldn't have known about this review request...

I assume it's obsolete at this point @mbarnach?

Again: sorry. This is shameful of me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants