Misc ci remove swift4x #1558
Open
Misc ci remove swift4x #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarnach
reviewed
Sep 21, 2021
| @@ -38,7 +38,7 @@ final class TestServer: KituraTest, KituraTestSuite { | |||
| } | |||
|
|
|||
| var httpPort = 8080 | |||
| let useNIO = ProcessInfo.processInfo.environment["KITURA_NIO"] != nil | |||
| let useNIO = ProcessInfo.processInfo.environment["KITURA_NIO"] != "0" | |||
There was a problem hiding this comment.
@dannys42 Are you inverting the NIO logic on purpose here or for convenience?
There was a problem hiding this comment.
Yes, I'm inverting the KITURA_NIO logic to make NIO the default (on our path to deprecating the Kitura-net repo). This has the advantage of working in iOS and other Xcode projects, which is great for using Kitura as a mock server for unit testing. I'll update the readme to include this note.
…stExpectation is not guaranteed to be thread safe.
- Tests can now run concurrently - Removed global state when launching servers - Specify "localhost" when creating servers to avoid macOS "allow network" UI alert
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.