Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Issues in PR(Share GPU ressources across render windows) #3059

Closed
zzzhello opened this issue Apr 13, 2024 · 1 comment · Fixed by #3060
Closed

[Bug] Issues in PR(Share GPU ressources across render windows) #3059

zzzhello opened this issue Apr 13, 2024 · 1 comment · Fixed by #3060
Assignees
@bruyeret
Labels
released Automated label type: bug 🐞 Errors in functionality type: feature request 💡 Desired capabilities / enhancements

Comments

@zzzhello
Copy link

zzzhello commented Apr 13, 2024 •
edited

Bug description

About PR(#3051), It is a great solution for share GPU memory in vtk.js . I tried and find two issues.

  1. renderer.getRenderWindow().getViews() return [] for some classes. If i use pick() in Picker.js, it will throw error "Uncaught TypeError: Cannot read properties of undefined (reading 'getViewportSize')" , I think 'renderWindow.addView(renderWindowView)' is missing after 'mainRenderWindowView.addMissingNode(renderWindow)' called

  2. ‘ImageResliceMapper’should also be changed same as 'VolumeMapper', beacause it's also use GPU to render MPR images.

Steps to reproduce

  1. use ‘ImageResliceMapper’ to create overy two MPR windows
  2. check is the GPU memory(texture) shared between two MPR windows
  3. call 'renderer.getRenderWindow().getViews()' , it will return empty array

Detailed Behavior

No response

Expected Behavior

  1. GPU memroy should be shared
  2. 'renderer.getRenderWindow().getViews()' should not be empty

Environment

  • vtk.js version: 30.4.0
  • Browsers: chrome
  • OS: windows11
@zzzhello zzzhello added the type: bug 🐞 Errors in functionality label Apr 13, 2024
@finetjul finetjul added the type: feature request 💡 Desired capabilities / enhancements label Apr 15, 2024
@bruyeret bruyeret mentioned this issue Apr 16, 2024
Merged
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 30.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bruyeret bruyeret

Labels
released Automated label type: bug 🐞 Errors in functionality type: feature request 💡 Desired capabilities / enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ImageResliceMapper and improve example bruyeret/vtk-js
3 participants
@finetjul @zzzhello @bruyeret