Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ImageResliceMapper and improve example #3060

Merged
merged 2 commits into from
May 30, 2024

Conversation

bruyeret
Copy link
Contributor

Fixes the issues mentionned in #3059

The picking has been tested and should work fine.

I kept it in a stash but it is maybe better to share it in a branch:
I modified the HW selector test to show that picking still works in the children render windows in my fork.

Close #3059

Same issue as for the volume mapper in the commit :
2fadb43
Also add `addView` call (this didn't cause any bug, but it is better for the example)
@bruyeret bruyeret requested a review from finetjul April 16, 2024 13:28
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floryst floryst added this pull request to the merge queue May 30, 2024
Merged via the queue into Kitware:master with commit ac4d712 May 30, 2024
3 checks passed
@bruyeret bruyeret deleted the fix-multi-rw branch May 30, 2024 17:20
Copy link

🎉 This PR is included in version 30.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Issues in PR(Share GPU ressources across render windows)
3 participants