refactor(WebGL): remove support for WebGL1 #2212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that safari supports webgl2 move to that as the webg1 code and conditionals added a lot of complexity and limited what we could do. Now that WebGL2 is fairly universal this change should not break anything other than iOS devices still running iOS 14 or earlier. There is a second step (not in this MR) which is to update vtk.js to assume that we have depth textures. This will remove the need for the opaque depth pass code and some other sections of code but to keep this MR reasonably small it is being left out.
|
Going to let this sit for a bit as I'm not sure how much iOS 14 is still out there in the wild right now. |
|
Here are Mixpanel's iOS 14 and 15 usage stats: https://mixpanel.com/trends/#report/ios_15 |
|
We should still ask the community once we are getting closer to the time where we want to merge that. As I'm worried that some of the usage of vtk.js would be in hospitals on iOS devices... On the other hand, they could still use older version of vtk.js to keep things working... |
3 tasks
|
iOS 17 is released and iOS 14 market share is less than 0.05% https://telemetrydeck.com/blog/ios-market-share-13-23/ |
|
Three.js will remove support for WebGL1 in r163 which is due in March or April 2024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that safari supports webgl2 move to that as the webg1 code
and conditionals added a lot of complexity and limited what
we could do.
Now that WebGL2 is fairly universal this change should not
break anything other than iOS devices still running iOS 14
or earlier.
There is a second step (not in this MR) which is to update vtk.js
to assume that we have depth textures. This will remove the need
for the opaque depth pass code and some other sections of code
but to keep this MR reasonably small it is being left out.