feat(XR): Handle WebXR XRInputSourceEvents #2221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that XR events seem at the moment to be the best way to handle mobile AR events, which will usually be simpler (i.e. touching the screen). VR events may be more complicated due to different controller inputs/configurations. |
floryst
reviewed
Jan 17, 2022
Comment on lines
+62
to
+67
| 'StartXrSelect', | ||
| 'XrSelect', | ||
| 'EndXrSelect', | ||
| 'StartXrSqueeze', | ||
| 'XrSqueeze', | ||
| 'EndXrSqueeze', |
There was a problem hiding this comment.
I think capitalizing the 'R' in 'XR' for consistency is a good idea here.
|
Note that I do not expect to be able to revisit this PR. Will leave open in case others would like to take up this development, otherwise project maintainers are welcome to close it. |
|
this PR is probably useful so we should just merge it someday imo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR and Code Checklist
npm run reformatto have correctly formatted codeContext
The WebXR API exposes a limited number of user input events, which we expose to the user here through
RenderWindowInteractoralongside other typical browser events.Note that the granularity offered through XR events does not match that of the XR gamepad API, through which we can query continuous values such as touchpad or joystick position through our
updateXRGamepadsmethod. Developers should take both approaches into account.Changes
RenderWindowInteractor.Results
Exposes six new events ("select"/start/end, "squeeze"/start/end) that developers can choose to handle.
Testing
master