feat(objwriter): add support for vtkOBJWriter #2405
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
reviewed
May 8, 2022
daker
force-pushed
the
add-objwriter
branch
2 times, most recently
from
68353a6
to
175a919
Compare
finetjul
reviewed
May 9, 2022
finetjul
reviewed
May 9, 2022
| /** | ||
| * vtkOBJWriter writes wavefront obj (.obj) files in ASCII form. OBJ files | ||
| * contain the geometry including lines, triangles and polygons. Normals and | ||
| * texture coordinates on points are also written if they exist. |
There was a problem hiding this comment.
you might want to mention that materials are not written out.
There was a problem hiding this comment.
I have written the code for the mlt part, but i don't know how it can be exposed? user need to pass the vtkTexture? or just pass the texture filename?
@jourdain do you have any idea how to expose the texture export?
There was a problem hiding this comment.
yes, a vtkTexture (or vtkImageData?) would need to be optionnally passed (i.e. as a second input macro.algo(publicAPI, model, 2, 1);)
I guess it could output the mtl part in a second output (i.e. macro.algo(publicAPI, model, 1, 2); and outData[1] = ... )
There was a problem hiding this comment.
ok i will re-add the mtl code again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2404
Context
Add support for vtkOBJWriter
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting