-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add GTLFReader #2479
base: master
Are you sure you want to change the base?
WIP: add GTLFReader #2479
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Hi @daker , Any progress there? |
This comment was marked as resolved.
This comment was marked as resolved.
Hi @daker, I may start looking into it. Do you have a feel of how much more work needs to go into it? Do you think we can reformat/rebase and merge it in its current state, or would it be better to work on the same branch until X and Y are solved? If so, knowing what X and Y are would be great. Thanks for your hard work pushing vtk.js forward, Seb |
I have updated the description with a list of questions/features to be addressed. Basically the loader is able to parse the gltf with simple embedded resources like the box or colored box. As you can see on the images, there is something missing in the code to render those boxes correctly, @finetjul told me that faces/cells do not seem to be made of the right point ids, i am not good on this part. My idea is to have a simple SceneLoader that will act like this : I would suggest to work on a branch, once we have a basic SceneLoader with basic parsing and rendering then we can merge and iterate over with adding animations and extensions depending on what we have decided. |
Sounds good, thanks for the update. |
@jourdain I am back working on this, i made some very good progress, no animation, lights , cameras, skins, morph or extensions so far The ORM textures are slow to display since they are computed(using canvas) by extracting the channels from a the combined texture, this should be done by the GPU like in vtk c++ by providing a setORMTexture (FYI @martinken) screen-capture.2.webm |
Context
This is a draft PR, a starting point to learn what's missing to render the GLTF correctly
Results
Changes
PR and Code Checklist
npm run reformat
to have correctly formatted codeTesting