fix(ImageResliceMapper): Axis orthogonality, Image size and texture coordinates #3064
Conversation
…ified when using slicePlane
yarous224
force-pushed
the
fix(imagereslicemapper)
branch
from
5ad9063
to
a8b7a5c
Compare
Image SizeThe polygons generated by ImageResliceMapper do not take into account the size of the pixels themselves. This is a 512*512 spacing 0.782 image. It length is 400.384mm. Before Change:
After Change:
|
yarous224
changed the title
Texture coordinatesImageResliceMapper does not account for the 0.5 offset of the texture matrix when calculating the matrix from world coordinates to texture coordinates, resulting in behavior that is inconsistent with other software (e.g., Radiant). Before Change |
|
@sankhesh can you take a look? |
| @@ -1217,7 +1221,14 @@ function vtkOpenGLImageResliceMapper(publicAPI, model) { | |||
| ); | |||
| const otherAxes = [(orthoAxis + 1) % 3, (orthoAxis + 2) % 3].sort(); | |||
| const dim = image.getDimensions(); | |||
| const ext = [0, dim[0] - 1, 0, dim[1] - 1, 0, dim[2] - 1]; | |||
| const ext = [ | |||
There was a problem hiding this comment.
Please use image.getSpatialExtent here.
| @@ -1133,17 +1138,16 @@ function vtkOpenGLImageResliceMapper(publicAPI, model) { | |||
| resGeomString = resGeomString.concat(`Plane${slicePlane.getMTime()}`); | |||
| if (image) { | |||
| resGeomString = resGeomString.concat(`Image${image.getMTime()}`); | |||
| // Check to see if we can bypass oblique slicing related bounds computation | |||
There was a problem hiding this comment.
I'm not sure I follow the reason for this change. Firstly, this function will not be called unless there is an input(
vtk-js/Sources/Rendering/OpenGL/ImageResliceMapper/index.js
Lines 121 to 126 in a8b7a5c
const w2io = mat3.fromValues(image?.getDirection());mat3.fromValuesneeds expanded array, the old version would output a matrix full of NaN here.Context
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting