Warn and return when node_tests
are empty
#104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When working on #103 an edge case was observed where a pattern (or list in #103) resulting
allocator.node_tests
when smaller then the number ofCI_NODES
results in 1-n nodes executing the complete test suite.relevant line in rspec runner (bug applies to all runners):
knapsack/lib/knapsack/runners/rspec_runner.rb
Line 15 in d9abb66
This interpolated string, with an empty
node_tests
array results in the following command being executed (assuming a test-dir ofspec
and no additional args):bundle exec rspec --default-path spec --
This behaves the same as
bundle exec rspec --default-path spec
which executes all specs.Solution
This PR adds a guard clause to all runners to return whenever the
node_tests
is empty for a given node. This seems to be the desired behavior: there are no specs left to execute for this node, so do nothing.