New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(translatable): Improve the LocaleSubscriber implementation #715

Open

damienalexandre wants to merge 2 commits into KnpLabs:master from damienalexandre:patch-1

damienalexandre commented Nov 2, 2022

Also fix some English / improve the flow of the document.

At the start all I wanted to replace was the locale parsing / setLocale on the Request thing to use modern Symfony:

$request->setLocale(
    $request->getPreferredLanguage($this->availableLocales)
);
$request->attributes->set('_vary_by_language', true);

damienalexandre and others added 2 commits

November 2, 2022 22:23


          doc(translatable): Improve the LocaleSubscriber implementation

00b47ad

Also fix some English / improve the flow of the document.


          doc(translatable): Fix the missing availableLocales property

56655f5

Author

damienalexandre commented Oct 3, 2023

Gentle ping about this pull request, is there anything I can do to help you review it?

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment