Bug 25727: (follow-up) Use CSS specificity rather than !important

This patch adds specificty to the CSS which controls the "invalid" appearance of a Select2 dropdown so that the use of "!important" can be avoided. The patch also puts this style into our custom select2 CSS file so that it is located with other Select2 style changes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha-Community · Aug 24, 2020 · 18139a8 · 18139a8
1 parent 424187b
commit 18139a8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/koha-tmpl/intranet-tmpl/prog/css/select2.css b/koha-tmpl/intranet-tmpl/prog/css/select2.css
@@ -2,11 +2,8 @@
     background-color: initial;
 }
 
-.select2-container.subfield_not_filled .select2-choice {
-    background: initial;
-    background-color : #FFFF99;
+.select2-container.missing .select2-choice,
+.select2-container .select2-selection--single.subfield_not_filled,
+.select2-container .select2-selection--single.important_subfield_not_filled {
+    background-color: #FFFF99;
 }
-
-.select2-container.missing .select2-choice {
-    background: #ffc none;
-}
diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
@@ -1552,11 +1552,11 @@ input[type='text']:read-only:focus {
 }
 
 .subfield_not_filled {
-    background-color: #FFFF99 !important;
+    background-color: #FFFF99;
 }
 
 .important_subfield_not_filled {
-    background-color : #FFFFCC !important;
+    background-color : #FFFFCC;
 }
 
 .content_hidden {