feat: rate-limit konnect requests when receiving 429s #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGabriele
force-pushed
the
feat/rate-limiting
branch
from
0ef7ffe
to
6f96f8d
Compare
hbagdi
reviewed
Jun 30, 2022
GGabriele
force-pushed
the
feat/rate-limiting
branch
4 times, most recently
from
88b4081
to
2eecede
Compare
Codecov Report
@@ Coverage Diff @@
## main #705 +/- ##
==========================================
- Coverage 43.50% 43.28% -0.23%
==========================================
Files 74 74
Lines 8923 8969 +46
==========================================
Hits 3882 3882
- Misses 4671 4717 +46
Partials 370 370
Continue to review full report at Codecov.
|
tjasko
reviewed
Jul 1, 2022
There was a problem hiding this comment.
Changes seem sane, however, aren't we waiting on hashicorp/go-retryablehttp#168 to get merged?
That's not a blocker, because the way decK uses the underlying library via |
tjasko
previously approved these changes
Jul 5, 2022
GGabriele
force-pushed
the
feat/rate-limiting
branch
from
b5c967a
to
0eb2151
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.