Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set source URLs for moved EE plugins #7386

Merged
merged 3 commits into from
May 17, 2024

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented May 15, 2024

Description

A bunch of EE plugins were moved to a new directory, breaking the "Edit this page" links on their schema config reference pages. This PR adds a source_url to each moved plugin to use as the link for editing.

https://konghq.atlassian.net/browse/DOCU-3841

Testing instructions

For example, see https://deploy-preview-7386--kongdocs.netlify.app/hub/kong-inc/response-transformer-advanced/configuration/

Checklist

@lena-larionova lena-larionova added the review:tech Request for technical review on the docs platform or processes. label May 15, 2024
@lena-larionova lena-larionova requested a review from a team as a code owner May 15, 2024 18:07
Copy link

netlify bot commented May 15, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 6be8cf0
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/664678651a6a0f0008c8ca32
😎 Deploy Preview https://deploy-preview-7386--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Some plugins were moved out of /kong/ee-plugins/ to /kong/plugins

Use `source_url` for the edit link when available, if not fall back to
the previous implementation.
@fabianrbz
Copy link
Contributor

fabianrbz commented May 16, 2024

@lena-larionova I pushed some changes, what do you think about renaming source_url to schema_source_url?
I think that source_url might be too generic.

@lena-larionova lena-larionova merged commit 8c02874 into main May 17, 2024
15 checks passed
@lena-larionova lena-larionova deleted the chore/source-urls-for-plugins branch May 17, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:tech Request for technical review on the docs platform or processes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants