chore: Clean up plugin version tags #7395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lena-larionova
added
the
review:general
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Plugins now use if_version block
fabianrbz
approved these changes
May 21, 2024
fabianrbz
added a commit
that referenced
this pull request
May 28, 2024
This way they get required by Jekyll on build Fixes the build in Ubuntu by loading the plugins correctly before running the code. The problem was with the order the plugins were being loaded. Which used to work because jekyll-generator-single source was being manually required, but that was removed as part of #7395. Even without that required, it used to work because of the`priorities`. The jekyll-generator-single-source had the highets and that's why it was being loaded first. but now priorities changed so that no longer applies. Using the jekyll_plugins group in the Gemfile ensures that they are loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The plugin docs currently use a mix of
if_versionandif_plugin_versiontags.Cleaning up
if_plugin_versionand replacing withif_version, since the plugins now support it.We no longer need to match older plugin version names, as the older versions they referenced have since been archived (eg custom plugin version names like 0.1.0).
Testing instructions
Preview link:
Checklist