Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing require to spec #7398

Merged
merged 1 commit into from
May 17, 2024
Merged

Add missing require to spec #7398

merged 1 commit into from
May 17, 2024

Conversation

fabianrbz
Copy link
Contributor

Description

It failed in main sometimes if all previously loaded files didn't require ostruct

Testing instructions

Preview link:

Checklist

It failed in main sometimes if all previously loaded files didn't
require ostruct
@fabianrbz fabianrbz added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label May 17, 2024
@fabianrbz fabianrbz requested a review from a team as a code owner May 17, 2024 06:27
Copy link

netlify bot commented May 17, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 0f4bb87
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6646f8e596736600085da470
😎 Deploy Preview https://deploy-preview-7398--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Guaris Guaris merged commit 473ee01 into main May 17, 2024
28 checks passed
@Guaris Guaris deleted the require-ostruct-in-spec branch May 17, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants