updates cross-env to latest (from prior: August 2016 version) #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious what the tradeoffs would be if we remove TS_NODE_PROJECT and make the default base ES5/ESNext and module commonjs. |
|
@jackkav this PR is just a simple (nearly) noop dependency update. would you mind if we took the conversation about our usage of cross-env to a separate PR or discussion somewhere? |
dimitropoulos
added
the
dependencies
DMarby
reviewed
Mar 17, 2022
dimitropoulos
force-pushed
the
feat/update-cross-env
branch
from
997e9c5
to
6cb543b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could use an update. From looking at the release notes there are no changes that affect our use case. It turns out this library has been officially abandoned: kentcdodds/cross-env#257, but it can't hurt to be on a semi-recent version.
It's hard to reverse the clock now, but I'm nearly sure I hit a problem with cross-env once (in insomnia-app) and I wonder, now having learned how out of date it is, if this was the reason.