chore(deps) updates (all but insomnia) to use @jest/globals #4793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitropoulos
force-pushed
the
feat/jest-globals
branch
from
696ad6a
to
84c0eab
Compare
we really gotta look into this... I tried to actually use the ImportRequest type but it results in dozens of legit errors. fell back to previous implementation using Record<string, any>[]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work was scoped out of the recent PR to move to jest 28 for the sake of time and complexity. I am therefore following up with it here.
There are enough tests in the insomnia package that I opted to do all but that package in this PR and hopefully get this PR merged quickly then move on to just the insomnia package as to reduce rebase-workload.
for anyone interested to learn more about
@jest/globalsDefinitelyTyped/DefinitelyTyped#44365 is a decent primer. the TLDR; is that it allows us to use jest without globals (which, for us, means that we can't then accidentally call jest globals from our non-test source code).