Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump playwright to 1.30 canary #5684

Merged
merged 3 commits into from Jan 18, 2023
Merged

bump playwright to 1.30 canary #5684

merged 3 commits into from Jan 18, 2023

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Jan 16, 2023 •
edited

Bumping to 1.29.2 1.30 canary

test:build works - but test:dev doesn't ⚠️

@filfreire filfreire requested a review from a team January 16, 2023 17:04
@filfreire filfreire self-assigned this Jan 16, 2023
@pavkout
Copy link
Contributor

pavkout commented Jan 17, 2023

@filfreire Check these related github issues.

microsoft/playwright#18928

microsoft/playwright#19246

microsoft/playwright#19412

@filfreire filfreire marked this pull request as ready for review January 17, 2023 14:01
@filfreire filfreire changed the title bump playwright to 1.29.2 bump playwright to 1.30 canary Jan 17, 2023
@filfreire filfreire force-pushed the chore/bump-playwright branch 2 times, most recently from 263884d to 1f4e260 Compare January 17, 2023 15:11
pavkout
pavkout approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@pavkout pavkout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works well 👍

@pavkout pavkout merged commit aa0f225 into Kong:develop Jan 18, 2023
@filfreire filfreire deleted the chore/bump-playwright branch January 25, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavkout pavkout pavkout approved these changes

Assignees

@filfreire filfreire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@filfreire @pavkout @gatzjames