Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for multiple windows #6010

Closed
wants to merge 3 commits into from
Closed

Conversation

tlund101
Copy link

@tlund101 tlund101 commented Jun 1, 2023

This PR relates to #5601 and fixes a regression (reported in #5761 ) caused by #5377
Work is being tracked internally by INS-2235 as well.

I've tested deep links on mac and they still work fine. I'm unable to test CLI arguments on Mac, as it always attempts to open a second instance, instead of hitting the second-instance event of Electron. Another thing I wasn't able to test is changing titles of different windows.

There may be more esoteric features of Insomnia I didn't test, but the basic collection creation and request functionality seems to work. Editing two things at the same time isn't supported, but also doesn't cause any errors. For example, editing an environment will save the environment that is closed/edited last.

Unfortunately in my second commit I had to remove the accelerator for a new window, since it would also send Cmd+N (creating a new request) at the same time it created a new window. I suspect this is a current issue in the release branch, though, if you change hotkeys to match accelerators.

@jackkav
Copy link
Contributor

jackkav commented Jul 7, 2023

thanks for the contribution, I picked this up and completed it over here #6104
should be in the next release

@jackkav jackkav closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants