Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can navigate to folder and inherit auth #7353

Merged
merged 23 commits into from May 17, 2024

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented May 2, 2024

motivation: shared auth is a 4 year old ask.
goal of this PR: add folder navigation and tabs, ensure all auth methods are supported for http requests

TODO

  • can navigate to folder
  • can edit docs
  • can edit and use auth
  • can select inherit as an auth option
  • test oauth2 auth window
  • test auth inheritance
  • test with sync
  • only toggle folder open on icon click

split into second pass

  • can edit and use prerequest scripts
  • support websocket only auth inheritance
  • refactor auth components
  • add a separator under new items in request/group context menus

nice to have

  • can edit folder level headers
  • can edit and use env vars (what event to save on)
  • docs editor is inlined

closes INS-3731

aiming to address #3518

challenges

  • executing scripts in scopes in order to avoid collision
  • testing
  • auth components are hard to extend
  • kvp editor is legacy
  • env vars are usually edited in a modal

@jackkav jackkav changed the title can navigate to folder can navigate to folder and inherit auth and script May 16, 2024
@jackkav jackkav marked this pull request as ready for review May 17, 2024 09:15
gatzjames
gatzjames previously approved these changes May 17, 2024
@jackkav jackkav changed the title can navigate to folder and inherit auth and script can navigate to folder and inherit auth May 17, 2024
@jackkav jackkav merged commit 5e67376 into Kong:develop May 17, 2024
7 checks passed
@jackkav jackkav deleted the spike/navigate-to-folder branch May 17, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants