Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: allow installation using a specified GatewayAPI commit #5808

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

tao12345666333
Copy link
Member

What this PR does / why we need it:

There are two ways to install GWAPI CRDs in our testing:

However, kustomize does not support the use of short commits generated by go mod,
and go mod also does not support the use of full commit hashes.

This PR introduces a new variable, GATEWAY_API_PACKAGE_VERSION. It will automatically resolve the package version in dependencies through go mod and allow us to use the full commit hash to use the GATEWAY API package.

Which issue this PR fixes:

Special notes for your reviewer:

This PR is from
91d2c60

I used a specific commit hash of GWAPI in #5776 and it has passed the test.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

- [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@tao12345666333 tao12345666333 requested a review from a team as a code owner April 3, 2024 23:29
@tao12345666333 tao12345666333 self-assigned this Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0%. Comparing base (2888908) to head (2d26a59).
Report is 36 commits behind head on main.

❗ Current head 2d26a59 differs from pull request most recent head c568899. Consider uploading reports for the commit c568899 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5808     +/-   ##
=======================================
+ Coverage   73.9%   74.0%   +0.1%     
=======================================
  Files        176     176             
  Lines      18185   18185             
=======================================
+ Hits       13445   13468     +23     
+ Misses      3737    3721     -16     
+ Partials    1003     996      -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I maybe misread somewhat earlier; looking again that value maybe isn't used outside that one Makefile generate target, i.e. not in tests per se?

envtest doesn't fail when invoked direct from go test, so I guess that's double confirmation this doesn't introduce any new environment requirement.

@tao12345666333 tao12345666333 merged commit 627f686 into main Apr 10, 2024
36 checks passed
@tao12345666333 tao12345666333 deleted the test-allow-use-gwapi-commit branch April 10, 2024 21:09
@tao12345666333
Copy link
Member Author

Yes.

@tao12345666333 tao12345666333 mentioned this pull request Apr 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants