Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump controller-runtime to v0.18 and k8s to v0.30 #5980

Closed
wants to merge 1 commit into from

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented May 7, 2024

What this PR does / why we need it:

Bumps and adapts to controller-runtime v0.18 that introduced breaking changes affecting us in kubernetes-sigs/controller-runtime#2783. Bumps k8s dependencies to v0.30 as well along with it.

Which issue this PR fixes:

Unblocks #5978.

@czeslavo czeslavo self-assigned this May 7, 2024
@czeslavo czeslavo added the area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. label May 7, 2024
@czeslavo czeslavo force-pushed the bump-k8s-1.30 branch 3 times, most recently from 33b5e6b to 1b22bb7 Compare May 7, 2024 17:33
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 92.28650% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 72.1%. Comparing base (c722afb) to head (9485c19).

Files Patch % Lines
...ers/configuration/kongupstreampolicy_controller.go 79.5% 7 Missing and 3 partials ⚠️
...trollers/configuration/zz_generated_controllers.go 93.6% 8 Missing ⚠️
...ternal/controllers/gateway/grpcroute_controller.go 92.0% 1 Missing and 1 partial ⚠️
...ternal/controllers/gateway/httproute_controller.go 93.5% 1 Missing and 1 partial ⚠️
...nternal/controllers/gateway/tcproute_controller.go 92.0% 1 Missing and 1 partial ⚠️
...nternal/controllers/gateway/tlsroute_controller.go 92.0% 1 Missing and 1 partial ⚠️
...nternal/controllers/gateway/udproute_controller.go 92.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5980     +/-   ##
=======================================
- Coverage   72.4%   72.1%   -0.4%     
=======================================
  Files        180     180             
  Lines      18430   18414     -16     
=======================================
- Hits       13345   13278     -67     
- Misses      4100    4187     +87     
+ Partials     985     949     -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo force-pushed the bump-k8s-1.30 branch 3 times, most recently from 7a203ef to 8f59201 Compare May 7, 2024 18:16
@czeslavo
Copy link
Contributor Author

czeslavo commented May 8, 2024

Closing in favor of #5935.

@czeslavo czeslavo closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant