Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): downgrade vue-tsc for type errors #348

Merged
merged 4 commits into from Apr 25, 2023

Conversation

adamdehaven
Copy link
Collaborator

Summary

Downgrade vue-tsc to version 1.2.0 to resolve built type errors stemming from version 1.2.1

Link to opened issue: vuejs/language-tools#2714

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@adamdehaven adamdehaven self-assigned this Apr 25, 2023
Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamdehaven adamdehaven merged commit b3bf351 into main Apr 25, 2023
6 checks passed
@adamdehaven adamdehaven deleted the fix/app-layout-type-exports branch April 25, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants