Fix task name in error message for missing .api files (and add some hints) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
reviewed
Apr 11, 2022
Sorry about that, it seems I updated one word in the error message after running the tests. Will fix ASAP |
…ensitivity Resolves: Kotlin#76
joffrey-bion
force-pushed
the
jbion/fix-error-message
branch
from
2dba7c7
to
eb284ce
Compare
|
Sorry, we've fixed it all separately and the changeset is no longer relevant. |
|
Sure, no worries. If the task name thing was fixed too, it's alright then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the task name bug mentioned in this issue: #76
And also provides some hints about project renames (when a file is found with an incorrect name) and suggest deletion in case the rename is case-change-only.
I'm sorry if the diff is a bit chaotic, I tried to simplify some stuff in the implementation that accesses the files. Not sure why the objectfactory / filetrees were used there instead of plain listFiles().