Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for .api file in a case-insensitive manner #79

Merged
merged 1 commit into from Apr 15, 2022

Conversation

qwwdfsad
Copy link
Member

Fixes #76

@qwwdfsad qwwdfsad requested a review from ilya-g April 11, 2022 16:48
@ilya-g
Copy link
Member

ilya-g commented Apr 15, 2022

Maybe it's worth to log a warning when the case of an api file name doesn't match the expected case?
Could apiDump task be changed to normalize the case of the file name?

@qwwdfsad
Copy link
Member Author

Sorry, thought we've discussed it on meeting, should've written the rationale anyway.

The problem with mixed case sensitive/case-insensitive is that there is no single source of truth -- if the project is being developed exclusively on OS X, than CamelProjectCase can be preferable over normalized file name. Normalizing it will also trigger disruptive change for everyone updated, which isn't a good thing.

Also, the original issue (slackhq/EitherNet#52) is really weird and it's hard to tell whether a single change in minor Gradle version leading to changing the case of project name in the Gradle model a desired behaviour or a bug and triggering a warning over such thing doesn't seem reasonable to me.

@qwwdfsad qwwdfsad merged commit fc376fb into master Apr 15, 2022
@qwwdfsad qwwdfsad deleted the fix-case-sensitivity branch April 15, 2022 12:06
@ZacSweers
Copy link

unfortunately it looks like it still fails in 0.9.0 :/. Same PR

@ZacSweers
Copy link

part of the problem is that it uses the project name (which has capital letters). If I regenerate it with all lowercase, then it works. It does seem to expect it to be all lowercase though when checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top-level projects don't seem to work on all OS's
3 participants