Skip to content

Commit

Permalink
Improve code style
Browse files Browse the repository at this point in the history
  • Loading branch information
vmishenev committed Dec 20, 2021
1 parent 848a8b0 commit 472a4da
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
Expand Up @@ -81,9 +81,12 @@ class DocumentableVisibilityFilterTransformer(val context: DokkaContext) : PreMe
return Pair(packagesListChanged, filteredPackages)
}

@Suppress("UNUSED_PARAMETER")
private fun <T : WithVisibility> alwaysTrue(a: T, p: DokkaSourceSet) = true
@Suppress("UNUSED_PARAMETER")
private fun <T : WithVisibility> alwaysFalse(a: T, p: DokkaSourceSet) = false
private fun <T> alwaysNoModify(a: T, sourceSets: Set<DokkaSourceSet>) = Pair(false, a)
@Suppress("UNUSED_PARAMETER")
private fun <T> alwaysNoModify(a: T, sourceSets: Set<DokkaSourceSet>) = false to a

private fun WithVisibility.visibilityForPlatform(data: DokkaSourceSet): Visibility? = visibility[data]

Expand Down Expand Up @@ -159,16 +162,14 @@ class DocumentableVisibilityFilterTransformer(val context: DokkaContext) : PreMe

val modified = setter?.first == true || getter?.first == true

Pair(modified,
val property =
if (modified)
with(original) {
copy(
setter = setter?.second?.firstOrNull(),
getter = getter?.second?.firstOrNull()
)
}
original.copy(
setter = setter?.second?.firstOrNull(),
getter = getter?.second?.firstOrNull()
)
else original
)
modified to property
}

return properties.transform(
Expand Down
Expand Up @@ -2,7 +2,6 @@ package transformers

import org.jetbrains.dokka.base.testApi.testRunner.BaseAbstractTest
import org.jetbrains.dokka.model.DEnum
import org.jetbrains.dokka.model.DProperty
import org.jetbrains.dokka.model.WithCompanion
import org.junit.jupiter.api.Test
import kotlin.test.assertEquals
Expand Down Expand Up @@ -101,7 +100,7 @@ class SuppressTagFilterTest : BaseAbstractTest() {
) {
preMergeDocumentablesTransformationStage = { modules ->
val prop = modules.flatMap { it.packages }.flatMap { it.properties }
.firstOrNull { it.name == "property" } as? DProperty
.find { it.name == "property" }
assertNotNull(prop)
assertNotNull(prop.getter)
assertNull(prop.setter)
Expand Down

0 comments on commit 472a4da

Please sign in to comment.