infrastructure: enable Gradle build cache by default #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
reviewed
Oct 19, 2022
In the documentation it describes how to disable caching
|
But this is |
|
I believe you just enable |
|
You are right! Thanks for checking. I've removed it. I see there's Maven caching for setup-java, which I must have gotten mixed up with. I'll make another PR for enabling that. https://github.com/actions/setup-java#caching-maven-dependencies |
aSemy
changed the title
aSemy
changed the title
aSemy
changed the title
IgnatBeresnev
approved these changes
Dec 13, 2022
IgnatBeresnev
added a commit
that referenced
this pull request
Jan 26, 2023
Because integration tests are cached by default, it produces no output for showcasing documentation through S3 or GitHub artifacts. Regression from #2711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables Gradle Build Cache. This should massively increase build speed on CI/CD as Gradle will be able to avoid doing repetitive work.
Since all of the GitHub Actions use the
gradle/gradle-build-actionaction, this will automatically share the Gradle Build Cache. (I also addedgradle/gradle-build-actionin the Maven workflow, because I expect the$USER_HOME/.m2will be shared and re-used - if not this can be revisited later).I expect that the GitHub Action build times will improve dramatically, especially for PRs like this where there are no code changes!
(Note that the caching won't be enabled on this PR, because by default only the master/main branch will cache. This is to avoid multiple jobs updating the cache concurrently.)